Skip to content

[core] Add test for create directory recursive util #32336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[core] Add test for create directory recursive util #32336

wants to merge 8 commits into from
+99 −12

Conversation

praasz
Copy link
Contributor

@praasz praasz commented Oct 8, 2025 •
edited
Loading

Details:

  • Add unit test in common utils ov::util::create_directory_recursive instead of test in GPU specific case only.
  • Add unit test utility for validation if create path is same as expected literals.
  • Update ov::util::make_path as helper to create std::filesystem::path and hide platform specific conversion issues when converting input string to path native format.
  • Use updated make path in core_impl as example.

Tickets:

@praasz praasz requested review from a team as code owners October 8, 2025 14:10
@github-actions github-actions bot added the category: IE Tests OpenVINO Test: plugins and common label Oct 8, 2025
@t-jankowski t-jankowski requested a review from barnasm1 October 8, 2025 14:28
@t-jankowski t-jankowski enabled auto-merge October 8, 2025 15:19
@praasz praasz force-pushed the add-test-for-create-directory-recursive-util branch from 5fb86df to 9cc5f50 Compare October 9, 2025 05:37
olpipi
olpipi approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@olpipi olpipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but what reason to create this PR? Just to improve coverage, or we had bug in create_directory_recursive?

@praasz praasz requested a review from a team as a code owner October 10, 2025 08:20
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label Oct 10, 2025
@praasz
Copy link
Contributor Author

praasz commented Oct 10, 2025

LGTM but what reason to create this PR? Just to improve coverage, or we had bug in create_directory_recursive?

The PR description will be updated with explanation.
The main goals are:

  • Add unit test for util function in utils instead keep it as GPU specific test
  • Add some additional verification to check if created directories are same as literals (there con be some hidden conversion on Windows)
  • Add some additional test utils for path validation which can be useful to check if there is no regression introduced during migration from string, etc, to fs::path

praasz added 2 commits October 10, 2025 10:13
@praasz
Update make_path util
c1b16a2 
Signed-off-by: Raasz, Pawel <[email protected]>
@praasz
Use make_path in core_impl
510f6a0 
Signed-off-by: Raasz, Pawel <[email protected]>
@github-actions github-actions bot added the category: inference OpenVINO Runtime library - Inference label Oct 10, 2025
@praasz
Uncomment test code
c17e82e 
Signed-off-by: Raasz, Pawel <[email protected]>
@praasz praasz added this to the 2025.4 milestone Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olpipi olpipi olpipi approved these changes

@t-jankowski t-jankowski t-jankowski approved these changes

@barnasm1 barnasm1 barnasm1 approved these changes

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
2025.4
Development

Successfully merging this pull request may close these issues.
5 participants
@praasz @olpipi @t-jankowski @barnasm1 @mlukasze